You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This removes the (unused?) dependency to the trilead-api plugin.
I'm probably missing some classloader(?) subtlety here, please feel free to
close if this is invalid...
This dependency was added by @timja in #11, so it serves... some purpose?
Since we don't use that dependency in this plugin and already get it through ssh-credentials, this seems to be redundant...
Testing done
Unit tests and mvn hpi:run "testing" only.
### Submitter checklist
- [x] Make sure you are opening from a **topic/feature/bugfix branch** (right side) and not your main branch!
- [x] Ensure that the pull request title represents the desired changelog entry
- [x] Please describe what you did
- [ ] Link to relevant issues in GitHub or Jira
- [ ] Link to relevant pull requests, esp. upstream and downstream changes
- [ ] Ensure you have provided tests - that demonstrates feature works or fixes the issue
there was previouisy some code in here to perfrom authentication for trilead ssh connections IIRC and this was then moved out.
Thus if you this plugin but not the other then you would end up with a loss of functionality. I think that was the use case and not sure how long ago that was to see if it safe to remove or not.
there was previouisy some code in here to perfrom authentication for trilead ssh connections IIRC and this was then moved out. Thus if you this plugin but not the other then you would end up with a loss of functionality. I think that was the use case and not sure how long ago that was to see if it safe to remove or not.
unsure exactly but this change was needed for bom to pass after the trilead-api split from core.
if bom passes with this change then it's fine I think.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This removes the (unused?) dependency to the trilead-api plugin.
I'm probably missing some classloader(?) subtlety here, please feel free to
close if this is invalid...
This dependency was added by @timja in #11, so it serves... some purpose?
Since we don't use that dependency in this plugin and already get it through
ssh-credentials, this seems to be redundant...Testing done
Unit tests and
mvn hpi:run"testing" only.